Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Go back to pnpm #756

Merged
merged 18 commits into from
Apr 11, 2024
Merged

chore: Go back to pnpm #756

merged 18 commits into from
Apr 11, 2024

Conversation

markflorkowski
Copy link
Collaborator

vitejs/vite#9731 is resolved

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:15am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 006ec32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

juliusmarminge
juliusmarminge reviewed Apr 11, 2024
View reviewed changes
examples/backend-adapters/package.json Outdated
Comment on lines 11 to 18
"dev:cf": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:cf\"",
"dev:elysia": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:elysia\"",
"dev:express": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:express\"",
"dev:fastify": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:fastify\"",
"dev:hono": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:hono\"",
"dev:h3": "concurrently \"pnpm --cwd client dev\" \"pnpm --cwd server dev:h3\"",
"build": "pnpm --cwd client build && pnpm --cwd server build",
"start": "concurrently \"pnpm --cwd client start\" \"pnpm --cwd server start\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be a npm workspace. pnpm workspaces doesn't work very well when they're nested

@juliusmarminge juliusmarminge added the release canary Trigger a canary release to npm label Apr 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected]

@github-actions github-actions bot removed the release canary Trigger a canary release to npm label Apr 11, 2024
@juliusmarminge juliusmarminge merged commit e51c154 into main Apr 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markflorkowski @juliusmarminge